/ Zope / Apsis / Pound Mailing List / Archive / 2006 / 2006-02 / segfault in svc.c if no session regex

[ << ] [ >> ]

[ SSL vhost - TLS Upgrade / Will Tatam ... ] [ problems compiling pound 2.0 / Alessio Cervellin ... ]

segfault in svc.c if no session regex
Zed Shaw <zedshaw(at)zedshaw.com>
2006-02-05 01:58:31 [ SNIP ]
Hey,

Really like Pound but the 2.0 release has a serious bug.  You need to  
do a:

if(svc->sess_type != S_NONE) upd_session(svc, &headers[1], cur_backend);

On line 1159 or the whole world dies in a horrible segfault death.

I'm not sure if this is the right way, but basically if upd_session  
is called when there's no session settings then the regexec in  
svc.c:get_HEADERS blows up bad.

Have you considered using something like http://www.hwaci.com/sw/ 
lemon/ to generate a parser rather than the hand coded one?

Anyway, liking Pound a lot.

Zed A. Shaw
http://www.zedshaw.com/


Re: [Pound Mailing List] segfault in svc.c if no session regex
Robert Segall <roseg(at)apsis.ch>
2006-02-06 11:56:39 [ SNIP ]
On Sat, 2006-02-04 at 19:58 -0500, Zed Shaw wrote:
> Hey,
> 
> Really like Pound but the 2.0 release has a serious bug.  You need to  
> do a:
> 
> if(svc->sess_type != S_NONE) upd_session(svc, &headers[1], cur_backend);
> 
> On line 1159 or the whole world dies in a horrible segfault death.
> 
> I'm not sure if this is the right way, but basically if upd_session  
> is called when there's no session settings then the regexec in  
> svc.c:get_HEADERS blows up bad.
> 
> Have you considered using something like http://www.hwaci.com/sw/ 
> lemon/ to generate a parser rather than the hand coded one?
> 
> Anyway, liking Pound a lot.
> 
> Zed A. Shaw
> http://www.zedshaw.com/

Thanks for that - this is most welcome. Probably the best way is to add
a check if svc->sess_type is S_COOKIE or S_HEADER right at the start of
upd_session (in svc.c) and return if not.

This will appear in the next release.
-- 
Robert Segall
Apsis GmbH
Postfach, Uetikon am See, CH-8707
Tel: +41-44-920 4904


MailBoxer