/ Zope / Apsis / Pound Mailing List / Archive / 2006 / 2006-02 / Bug in 2.0.2 CheckURL config?

[ << ] [ >> ]

[ Session Management / "Nima Mazloumi" ... ] [ Pound 2.02 + Keepalived Problem / "Kenneth ... ]

Bug in 2.0.2 CheckURL config?
Yiu-chung Lee <leeyc(at)school.hk>
2006-02-20 08:10:54 [ FULL ]
Dear developers,

I have found a bug in http.c in version 2.0.1.

Line 726 is
if(regexec(&lstn->url_pat, request, 0, NULL, 0))
i.e. the request header line is checked

But in line 727 is
logmsg(LOG_WARNING, "bad URL \"%s\" from %s", url, inet_ntoa(from_host));
i.e. the URL is logged.

e.g. if there is a request line of
GET /abc.htm HTTP/1.0

The whole "GET /abc.htm HTTP/1.0" will be compared while
/abc.htm will be logged only.

This would cause a problem in CheckURL config. If I specify the CheckURL
as "^/abc.htm$", I would not be able to match, since the string to be
compared is "GET /abc.htm HTTP/1.0".

Yiu-chung Lee

Re: [Pound Mailing List] Bug in 2.0.2 CheckURL config?
Robert Segall <roseg(at)apsis.ch>
2006-02-20 11:15:59 [ FULL ]
On Mon, 2006-02-20 at 15:10 +0800, Yiu-chung Lee wrote:[...]

You are right - many thanks for finding this. New version 2.0.2 is now
on-line, with the required fix.[...]

MailBoxer