On Sat, 2009-12-05 at 13:32 +0100, Jean-Pierre van Melis wrote:[...]
First of all: thanks for the kind words.
Now to the subject matter: I looked at the proposed patch and I can't
see that we'll adopt it. Here is our reasoning:
Benefit(s):
- the back-end sees the true originating IP address.
Disadvantages:
- not portable, single system (Linux only)
- very specific setup: the gateway must also be the Pound server. In
most cases that is not done - you usually have a gateway that does port
forwarding.
- software complexity: additional code is never healthy
- set-up complexity: Pound is dependent on netfilter being present,
correctly configured, with no conflicts
Seeing that the only benefit is that the logs would work with the IP
address rather than the X-Forwarded-for header (which can be configured
in practically all Web servers I know of), I don't think that this is
worth it.
I am aware that you put work into this, and, if you feel this is
important, I would be happy to add a link to the patch on the Pound
site, so people can easily find it.
In the meantime I hope we could concentrate on getting the 2.5 release
out.[...]
|